Skip to content

Arrays-2 Completed #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ankitakulkarnigit wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Arrays-2 Completed #1816

ankitakulkarnigit wants to merge 1 commit into from

Conversation

@ankitakulkarnigit
Copy link

@ankitakulkarnigit ankitakulkarnigit commented Oct 24, 2025

No description provided.

@super30admin
Copy link
Owner

super30admin commented Oct 24, 2025

  • Strengths:
    • The student demonstrates a strong understanding of in-place algorithms and efficient problem-solving techniques.
    • The code is clean, modular, and well-commented, making it easy to understand.
    • The solutions are optimal in terms of both time and space complexity.
  • Areas for Improvement:
    • The comment for gameOfLife mentions a time complexity of O(n^2) + O(n), which is incorrect. It should be O(m*n) since the problem involves a 2D matrix.
    • The docstring for gameOfLife could be more detailed to explain the rules and the approach more clearly.
    • The variable names in countAlive could be more descriptive (e.g., dirs could be directions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ankitakulkarnigit @super30admin